Refactor/eliminate lsp execute command#291
Open
nbfalcon wants to merge 4 commits intoemacs-lsp:masterfrom
Open
Refactor/eliminate lsp execute command#291nbfalcon wants to merge 4 commits intoemacs-lsp:masterfrom
nbfalcon wants to merge 4 commits intoemacs-lsp:masterfrom
Conversation
`lsp-execute-command' is a liability that needs to be removed; use lsp's :action-handlers for the reference and implementation lenses instead. Also remove the duplicate definition of the reference and implementation lens action functions.
Declare `lsp-lens-backend' where necessary.
Member
|
I'm a bit lost here. I assumed this is ready to merge? 🤔 @nbfalcon Can you resolve the conflicts? :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also do lsp-java-boot.el. I somehow forgot that one last time (this time I checked with counsel-projectile-rg).